kidshift/kidshift-be
3
0
Fork 0
mirror of https://github.com/r-ca/kidshift-be.git synced 2024-10-25 16:14:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

レスポンスするデータが無いときもエラーを返さないように

Browse Source
This commit is contained in:
ろむねこ 2024-07-10 14:13:07 +09:00
parent 2d1fb9a6ab
commit 0d22822496
Signed by: Fujimatsu
GPG Key ID: FA1F39A1BA37D168
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/routers/task/historyRouter.ts
View File

@ -1,8 +1,11 @@
import { notFoundResponse, requiredFieldMissingResponse } from '@src/models/commons/responses';
import { internalServerErrorResponse, notFoundResponse, requiredFieldMissingResponse } from '@src/models/commons/responses';
import { HistoryListResponse, HistoryResponse } from '@src/models/History';
import { getHistories } from '@src/services/historyService';
import { Router } from 'express';
import Logger from '@src/logger'
const logger = new Logger();
logger.setTag('historyRouter');
const parentRouter = Router(); // 親専用エンドポイント
const commonRouter = Router(); // 共用エンドポイント
@ -14,13 +17,12 @@ commonRouter.get("/:childId", (req, res) => {
return;
}
getHistories(childId).then((histories: HistoryResponse[]) => {
if (!histories || histories.length === 0) {
res.status(notFoundResponse().statusCode).send(notFoundResponse().body);
return;
}
res.status(200).send({
list: histories,
} as HistoryListResponse);
}).catch((err) => {
res.status(internalServerErrorResponse().statusCode).send(internalServerErrorResponse().body);
logger.error(err.message);
});
});