From ee5861ad2c2f4f3cfaae6d1d1ac27efa760694f6 Mon Sep 17 00:00:00 2001 From: rca Date: Sat, 6 Jul 2024 10:38:07 +0900 Subject: [PATCH 1/3] =?UTF-8?q?SharedPreference=E9=96=A2=E4=BF=82=E3=81=AE?= =?UTF-8?q?=E6=A9=9F=E8=83=BD=E3=82=92=E5=89=8A=E9=99=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/one/nem/kidshift/utils/KSLogger.java | 1 - .../nem/kidshift/utils/impl/KSLoggerImpl.java | 16 +--------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/utils/src/main/java/one/nem/kidshift/utils/KSLogger.java b/utils/src/main/java/one/nem/kidshift/utils/KSLogger.java index 7d7c62e..0593366 100644 --- a/utils/src/main/java/one/nem/kidshift/utils/KSLogger.java +++ b/utils/src/main/java/one/nem/kidshift/utils/KSLogger.java @@ -6,7 +6,6 @@ import one.nem.kidshift.utils.models.LogModel; public interface KSLogger { KSLogger addTag(String tag); - List getHistory(); void info(String message); void warn(String message); void error(String message); diff --git a/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java b/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java index ce33eaf..cf30c3b 100644 --- a/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java +++ b/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java @@ -21,12 +21,8 @@ import one.nem.kidshift.utils.models.LogModel; public class KSLoggerImpl implements KSLogger { private ArrayList tags = new ArrayList(); - - private SharedPrefUtils sharedPrefUtils; - @AssistedInject - public KSLoggerImpl(SharedPrefUtilsFactory sharedPrefUtilsFactory, @Assisted String name) { - sharedPrefUtils = sharedPrefUtilsFactory.create("KSLogger"); + public KSLoggerImpl(@Assisted String name) { tags.clear(); tags.add(name); } @@ -37,11 +33,6 @@ public class KSLoggerImpl implements KSLogger { return this; } - @Override - public List getHistory() { - return sharedPrefUtils.getObjects(LogModel.class); - } - @Override public void info(String message) { log(new LogModel(LogLevelEnum.INFO, tags.toArray(new String[0]), message)); @@ -73,14 +64,9 @@ public class KSLoggerImpl implements KSLogger { } private void log(LogModel log) { - addLog(log); outputLog(log); } - private void addLog(LogModel log) { - sharedPrefUtils.saveObject(log); - } - private void outputLog(LogModel log) { // ,区切りで出力 String tags = log.getTags().length > 0 ? String.join(",", log.getTags()) : "UNTAGGED"; -- 2.45.1 From 68321327ad8a120d731b484f124b8860613a5b9b Mon Sep 17 00:00:00 2001 From: rca Date: Sat, 6 Jul 2024 10:38:25 +0900 Subject: [PATCH 2/3] =?UTF-8?q?import=E6=95=B4=E7=90=86?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/one/nem/kidshift/utils/impl/KSLoggerImpl.java | 9 --------- 1 file changed, 9 deletions(-) diff --git a/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java b/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java index cf30c3b..059bd55 100644 --- a/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java +++ b/utils/src/main/java/one/nem/kidshift/utils/impl/KSLoggerImpl.java @@ -1,21 +1,12 @@ package one.nem.kidshift.utils.impl; -import static one.nem.kidshift.utils.enums.LogLevelEnum.INFO; - import android.util.Log; import java.util.ArrayList; -import java.util.Arrays; -import java.util.List; - -import javax.inject.Inject; - import dagger.assisted.Assisted; import dagger.assisted.AssistedInject; import one.nem.kidshift.utils.KSLogger; -import one.nem.kidshift.utils.SharedPrefUtils; import one.nem.kidshift.utils.enums.LogLevelEnum; -import one.nem.kidshift.utils.factory.SharedPrefUtilsFactory; import one.nem.kidshift.utils.models.LogModel; public class KSLoggerImpl implements KSLogger { -- 2.45.1 From d3614fc59f0316d623f854812dfb78cf97c26607 Mon Sep 17 00:00:00 2001 From: rca Date: Sat, 6 Jul 2024 10:40:35 +0900 Subject: [PATCH 3/3] =?UTF-8?q?getHistory=E3=82=92=E4=BD=BF=E7=94=A8?= =?UTF-8?q?=E3=81=99=E3=82=8B=E6=A9=9F=E8=83=BD=E3=82=92=E5=89=8A=E9=99=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../feature/debug/DebugCommandProcessor.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/feature/debug/src/main/java/one/nem/kidshift/feature/debug/DebugCommandProcessor.java b/feature/debug/src/main/java/one/nem/kidshift/feature/debug/DebugCommandProcessor.java index 51990e8..bef58b3 100644 --- a/feature/debug/src/main/java/one/nem/kidshift/feature/debug/DebugCommandProcessor.java +++ b/feature/debug/src/main/java/one/nem/kidshift/feature/debug/DebugCommandProcessor.java @@ -121,19 +121,7 @@ public class DebugCommandProcessor { commandArray = shiftArray(commandArray); switch (commandArray[0]) { case "get": - commandArray = shiftArray(commandArray); - switch (commandArray[0]) { - case "all": - List logs = ksLogger.getHistory(); - StringBuilder logString = new StringBuilder(); - for (LogModel log : logs) { - logString.append(log.getMessage()); - logString.append("\n"); - } - return logString.toString(); - default: - return "TODO"; - } + return "Removed for performance reasons"; case "insert": commandArray = shiftArray(commandArray); String[] logArray = Arrays.copyOfRange(commandArray, 1, commandArray.length); -- 2.45.1