kidshift/KidShift
3
0
Fork 0
Code Issues 9 Pull Requests Wiki Activity

Workaround: Threadの終了を待つように

Browse Source
This commit is contained in:
rca 2024-06-30 16:15:14 +09:00
parent 0c8eba1cb9
commit b3aa1549c9
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
data/src/main/java/one/nem/kidshift/data/impl/KSActionsImpl.java
View File

@ -56,7 +56,6 @@ public class KSActionsImpl implements KSActions {
private CompletableFuture<TaskSyncResult> doSyncTaskChild() {
return fetchChildListAsync().thenCombine(fetchTaskListAsync(), (childListResponse, taskListResponse) -> {
// 別スレッドでキャッシュに保存
Thread cacheThread = new Thread(() -> {
logger.debug("Updating cache in thread: " + Thread.currentThread().getId());
cacheWrapper.updateCache(ChildModelConverter.childListResponseToChildModelList(childListResponse),
@ -64,6 +63,14 @@ public class KSActionsImpl implements KSActions {
logger.info("Cache updated");
});
cacheThread.start();
try {
// Workaround: DBオペレーションを待たずに結果を先に返したいが、
// (現状(呼び出し元が)戻り値をそのままCallbackに渡しているために)
// キャッシュが空の場合のキャッシュ再取得のタイミングが調整できなくなる.
cacheThread.join();
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
return new TaskSyncResult() {
{
taskList = TaskModelConverter.taskListResponseToTaskItemModelList(taskListResponse);